Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: base/debug/trace_event_unittest.cc

Issue 12676007: Skip default categories when getting known categories. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/debug/trace_event_impl.cc ('K') | « base/debug/trace_event_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/trace_event_unittest.cc
diff --git a/base/debug/trace_event_unittest.cc b/base/debug/trace_event_unittest.cc
index 5fb90407c65df90867fbeff5b563616b47be1a03..14cef488e563ec50107507014e47257d7cebe77d 100644
--- a/base/debug/trace_event_unittest.cc
+++ b/base/debug/trace_event_unittest.cc
@@ -863,7 +863,9 @@ TEST_F(TraceEventTestFixture, Categories) {
EXPECT_TRUE(std::find(cats.begin(), cats.end(), "c2") != cats.end());
EXPECT_TRUE(std::find(cats.begin(), cats.end(), "c3") != cats.end());
EXPECT_TRUE(std::find(cats.begin(), cats.end(), "c4") != cats.end());
-
+ // Can't check the length as I don't know what other categories may have
nduca 2013/03/23 01:09:00 thats fine, but skip the first person voice and st
dsinclair 2013/03/25 14:22:57 Done.
+ // been added, so just make sure metadata isn't returned.
+ EXPECT_TRUE(std::find(cats.begin(), cats.end(), "__metadata") == cats.end());
const std::vector<std::string> empty_categories;
std::vector<std::string> included_categories;
std::vector<std::string> excluded_categories;
« base/debug/trace_event_impl.cc ('K') | « base/debug/trace_event_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698