Skip default categories when getting known categories.

base/debug/trace_event_impl.cc

Index: base/debug/trace_event_impl.cc
diff --git a/base/debug/trace_event_impl.cc b/base/debug/trace_event_impl.cc
index d543d873ac19998b4f8559254d4318d6a2b4482a..7de1cb675562edd37f0c1b72107babd4490f440a 100644
--- a/base/debug/trace_event_impl.cc
+++ b/base/debug/trace_event_impl.cc
@@ -74,7 +74,8 @@ unsigned char g_category_enabled[TRACE_EVENT_MAX_CATEGORIES] = { 0 };
 const int g_category_already_shutdown = 0;
 const int g_category_categories_exhausted = 1;
 const int g_category_metadata = 2;
-int g_category_index = 3; // skip initial 3 categories
+const int g_category_defined_start = 3;

[nduca, 2013/03/23 01:09:00]

this name is a bit awk. Skip builtin categories maybe?

SHould we just make the categories that begin with _ be not returned? The
strings used for the category names are not often printed, so it seems safe to
just have them start with underscores.

[dsinclair, 2013/03/25 14:22:57]

Changed to 'g_skip_builtin_categories'.

I think for now, what we have works. If we find we need to add more of these
default categories we can switch to the __ skipping scheme in the future.

+int g_category_index = g_category_defined_start; // skip default categories.
 
 // The name of the current thread. This is used to decide if the current
 // thread name has changed. We combine all the seen thread names into the
@@ -782,7 +783,7 @@ const unsigned char* TraceLog::GetCategoryEnabledInternal(const char* name) {
 
 void TraceLog::GetKnownCategories(std::vector<std::string>* categories) {
   AutoLock lock(lock_);
-  for (int i = 0; i < g_category_index; i++)
+  for (int i = g_category_defined_start; i < g_category_index; i++)
     categories->push_back(g_categories[i]);
 }