Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 12676004: Move ownership of cc:VideoLayer to webkit/media (Closed)

Created:
7 years, 9 months ago by danakj
Modified:
7 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, scherkus (not reviewing), qinmin, seivers_chromium.org
Visibility:
Public.

Description

Move ownership of cc:VideoLayer to webkit/media Currently the cc::VideoLayer is created and owned by the WebMediaPlayerClientImpl in WebKit. Communication with the cc::VideoLayerImpl then must be done though the WebVideoFrame and WebStreamTextureClient APIs. This CL moves the creation and ownership of the cc::Video layer to the WebMediaPlayer implementations in webkit/media, but does so behind a compiler flag until the WebKit side to match it lands and enables the flag. Then the communication between the WebMediaPlayer and cc::VideoLayerImpl can be done directly through the cc::VideoFrameProvider interface. This interface is implemented in the various implementations of WebMediaPlayer behind the compiler flag as well, to be enabled when WebMediaPlayerClientImpl stops implementing cc::VideoFrameProvider via WebVideoFrameProvider. Once the WebKit side lands and rolls, we can completely remove all mention of WebVideoFrame, WebVideoFrameProvider, and WebStreamTextureClientImpl. R=jamesr BUG=196810 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189979

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -25 lines) Patch
M content/renderer/media/stream_texture_factory_impl_android.cc View 5 chunks +24 lines, -1 line 0 comments Download
M webkit/media/android/stream_texture_factory_android.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.h View 7 chunks +28 lines, -3 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.cc View 1 2 3 7 chunks +58 lines, -12 lines 0 comments Download
M webkit/media/webkit_media.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/media/webmediaplayer_impl.h View 1 5 chunks +25 lines, -0 lines 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 1 2 3 8 chunks +50 lines, -7 lines 0 comments Download
M webkit/media/webmediaplayer_ms.h View 6 chunks +29 lines, -2 lines 0 comments Download
M webkit/media/webmediaplayer_ms.cc View 1 2 3 4 7 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
danakj
7 years, 9 months ago (2013-03-21 21:35:45 UTC) #1
danakj
This is just the bahaviour pieces of https://codereview.chromium.org/12902002/ behind flags. New code is ifdef'd. Old ...
7 years, 9 months ago (2013-03-21 21:36:55 UTC) #2
jamesr
lgtm! Be sure to carefully check that every file here that tests the #define includes ...
7 years, 9 months ago (2013-03-22 00:11:13 UTC) #3
danakj
On 2013/03/22 00:11:13, jamesr wrote: > lgtm! Be sure to carefully check that every file ...
7 years, 9 months ago (2013-03-22 04:12:27 UTC) #4
danakj
https://codereview.chromium.org/12676004/diff/1010/webkit/media/webmediaplayer_ms.cc File webkit/media/webmediaplayer_ms.cc (right): https://codereview.chromium.org/12676004/diff/1010/webkit/media/webmediaplayer_ms.cc#newcode404 webkit/media/webmediaplayer_ms.cc:404: DVLOG(3) << "WebMediaPlayerMS::getCurrentFrame"; On 2013/03/22 00:11:13, jamesr wrote: > ...
7 years, 9 months ago (2013-03-22 04:12:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12676004/2002
7 years, 9 months ago (2013-03-22 04:15:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12676004/2002
7 years, 9 months ago (2013-03-22 16:47:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12676004/2002
7 years, 9 months ago (2013-03-22 18:32:04 UTC) #8
danakj
7 years, 9 months ago (2013-03-23 03:30:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 manually as r189979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698