cc: Hook vsync time source to output surface

cc: Hook vsync time source to output surface

Let the output surface generate a vsync signal for the vsync time
source. This will be used to drive rendering based on a vsync
notification from the browser process.

BUG=149227
TEST=LayerTreeHostTestVSyncNotification


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190780

[Sami, 2013-03-22 15:17:04]

This patch implements what we need under cc/ to be able to drive the renderer
with an external vsync signal instead of the current timer approximation.
Generating the signal itself in the browser is left as future work since it will
look a little different for the browser and Android's WebView. PTAL, thanks.

(Depends on https://codereview.chromium.org/11414308/ for the setting.)

[mkosiba (inactive), 2013-03-22 15:33:17]

lgtm

[jamesr, 2013-03-23 00:35:29]

lgtm

https://codereview.chromium.org/12674030/diff/1/cc/test/fake_output_surface.h
File cc/test/fake_output_surface.h (right):

https://codereview.chromium.org/12674030/diff/1/cc/test/fake_output_surface.h...
cc/test/fake_output_surface.h:15: class TimeTicks;
Just include base/time.h

https://codereview.chromium.org/12674030/diff/1/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/12674030/diff/1/cc/trees/thread_proxy.cc#newc...
cc/trees/thread_proxy.cc:360: if (vsync_client_)
is it valid to call DidVSync without a vsync_client_? if not, could this be a
DCHECK() ?

https://codereview.chromium.org/12674030/diff/1/cc/trees/thread_proxy.cc#newc...
cc/trees/thread_proxy.cc:366: vsync_client_ = client;
I think it's worth tracing this too just to make it easier to debug if this call
for some reason never happens

[Sami, 2013-03-25 13:58:33]

https://codereview.chromium.org/12674030/diff/1/cc/test/fake_output_surface.h
File cc/test/fake_output_surface.h (right):

https://codereview.chromium.org/12674030/diff/1/cc/test/fake_output_surface.h...
cc/test/fake_output_surface.h:15: class TimeTicks;
On 2013/03/23 00:35:29, jamesr wrote:
> Just include base/time.h

Done.

https://codereview.chromium.org/12674030/diff/1/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/12674030/diff/1/cc/trees/thread_proxy.cc#newc...
cc/trees/thread_proxy.cc:360: if (vsync_client_)
On 2013/03/23 00:35:29, jamesr wrote:
> is it valid to call DidVSync without a vsync_client_? if not, could this be a
> DCHECK() ?

Because enabling and disabling the callback is done asynchronously, we can get a
call here even when the callback is off and vsync_client_ is null.

https://codereview.chromium.org/12674030/diff/1/cc/trees/thread_proxy.cc#newc...
cc/trees/thread_proxy.cc:366: vsync_client_ = client;
On 2013/03/23 00:35:29, jamesr wrote:
> I think it's worth tracing this too just to make it easier to debug if this
call
> for some reason never happens

Good idea, done.

[commit-bot: I haz the power, 2013-03-26 19:51:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/12674030/7001

[commit-bot: I haz the power, 2013-03-26 22:28:46]

Change committed as 190780