net/http/transport_security_state_static.json - Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/transport_security_state_static.json

Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete more code: CertificateErrorReporter::SendPinningViolationReport() Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/transport_security_state.cc ('K') | « net/http/transport_security_state_static.h ('k') | net/http/transport_security_state_unittest.cc » ('j') | net/url_request/certificate_report_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/transport_security_state_static.json

diff --git a/net/http/transport_security_state_static.json b/net/http/transport_security_state_static.json

index 96e9a567c7f86d32a3faec2b64920cc0a6dec8cc..7add3a8b84ae85955e390a96ce9ab8d5fcbe80f1 100644

--- a/net/http/transport_security_state_static.json

+++ b/net/http/transport_security_state_static.json

@@ -13,6 +13,8 @@

// static_spki_hashes: (list of strings) the set of allowed SPKIs hashes

// bad_static_spki_hashes: (optional list of strings) the set of forbidden

// SPKIs hashes

+// report_uri: (optional string) the URI to send violation reports to;

+// reports will be in the format defined in RFC 7469

// For a given pinset, a certificate is accepted if at least one of the

// "static_spki_hashes" SPKIs is found in the chain and none of the

@@ -41,7 +43,8 @@

"GoogleBackup2048",

"GoogleG2",

"GeoTrustGlobal"

- ]

+ ],

+ "report_uri": "http://clients3.google.com/cert_upload_json"

{

"name": "tor",