net/http/transport_security_state.cc - Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/transport_security_state.cc

Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete more code: CertificateErrorReporter::SendPinningViolationReport() Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/transport_security_state.cc

diff --git a/net/http/transport_security_state.cc b/net/http/transport_security_state.cc

index b343223430245fc9e3764cf770dba270e3c5b693..db03902a4a105a9897c88b8925f3a5419fbe8354 100644

--- a/net/http/transport_security_state.cc

+++ b/net/http/transport_security_state.cc

@@ -1033,6 +1033,9 @@ bool TransportSecurityState::GetStaticDomainState(const std::string& host,

return false;

const Pinset *pinset = &kPinsets[result.pinset_id];

+ if (pinset->report_uri != kNoReportUri)

agl 2015/08/07 23:10:01 Will need to be kNoReportURI since I changed the c

estark 2015/08/10 05:34:26 Done.

+ pkp_state->report_uri = GURL(pinset->report_uri);

if (pinset->accepted_pins) {

const char* const* sha1_hash = pinset->accepted_pins;

while (*sha1_hash) {

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | net/http/transport_security_state_static.h » ('j') | net/url_request/certificate_report_sender.cc » ('J')