chrome/chrome_browser.gypi - Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete more code: CertificateErrorReporter::SendPinningViolationReport() Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/chrome_fraudulent_certificate_reporter_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | net/http/transport_security_state.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 342bf07665bcba30ac90e8f3f541e449b98de7fb..c46402793cbd05053288c7c40483e978558ab85c 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -2755,8 +2755,6 @@

'browser/ssl/cert_report_helper.h',

'browser/ssl/certificate_error_report.cc',

'browser/ssl/certificate_error_report.h',

- 'browser/ssl/chrome_fraudulent_certificate_reporter.cc',

- 'browser/ssl/chrome_fraudulent_certificate_reporter.h',

'browser/ssl/chrome_ssl_host_state_delegate.cc',

'browser/ssl/chrome_ssl_host_state_delegate.h',

'browser/ssl/chrome_ssl_host_state_delegate_factory.cc',

@@ -3882,7 +3880,7 @@

{

- # Protobuf compiler / generator for the fraudulent certificate reporting

+ # Protobuf compiler / generator for the certificate error reporting

# protocol buffer.

# GN version: //chrome/browser/ssl:cert_logger_proto

'target_name': 'cert_logger_proto',