chrome/browser/net/certificate_error_reporter.h - Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/certificate_error_reporter.h

Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete more code: CertificateErrorReporter::SendPinningViolationReport() Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/net/certificate_error_reporter.h

diff --git a/chrome/browser/net/certificate_error_reporter.h b/chrome/browser/net/certificate_error_reporter.h

index f0d020fbb27e4855ac225e8c291a036c5fc6b6eb..dbfbb5b6527b3b234d30962663398f2a6cc70997 100644

--- a/chrome/browser/net/certificate_error_reporter.h

+++ b/chrome/browser/net/certificate_error_reporter.h

@@ -63,11 +63,6 @@ class CertificateErrorReporter {

virtual void SendExtendedReportingReport(

const std::string& serialized_report);

- // As |SendExtendedReportingReport|, but does not encrypt reports,

- // since the pinning violation server is not capable of handling

- // encrypted reports.

- virtual void SendPinningViolationReport(const std::string& serialized_report);

// Whether sending reports over HTTP is supported.

static bool IsHttpUploadUrlSupported();

« no previous file with comments | « no previous file | chrome/browser/net/certificate_error_reporter.cc » ('j') | net/http/transport_security_state.cc » ('J')