Allow preloaded pins to contain report URIs; remove special-case reporting

Allow preloaded pins to contain report URIs; remove special-case reporting

This CL processes report URIs in preloaded pins and removes special-case code
for reporting pin violations on Google properties
(FraudulentCertificateReporter and its implementation
ChromeFraudulentCertificateReporter), in favor of a preloaded report
URI.

BUG=445793
Committed: https://crrev.com/db949c345a8c561f45a2351daa06dc9c85671e88
Cr-Commit-Position: refs/heads/master@{#342967}

[estark, 2015-08-07 22:50:53]

estark@chromium.org changed reviewers:
+ agl@chromium.org

[estark, 2015-08-07 22:50:53]

agl, can you please review just net/http/transport_security_state_static.h and
.json? These are based on
https://github.com/agl/transport-security-state-generate/pull/6 (that is,
generated from transport-security-state-generate with that patch applied).

If you approve the transport-security-state-generate changes and
transport_security_state_static.*, then I'll get davidben to review the rest of
this CL (which is mostly just deleting code that is obviated by HPKP violation
reporting).

Thanks!

[agl, 2015-08-07 23:10:01]

LGTM.

https://codereview.chromium.org/1267383002/diff/40001/net/http/transport_secu...
File net/http/transport_security_state.cc (right):

https://codereview.chromium.org/1267383002/diff/40001/net/http/transport_secu...
net/http/transport_security_state.cc:1036: if (pinset->report_uri !=
kNoReportUri)
Will need to be kNoReportURI since I changed the capitalisation to meet my own,
selfish desires for Go style I'm afraid.

https://codereview.chromium.org/1267383002/diff/40001/net/url_request/certifi...
File net/url_request/certificate_report_sender.cc (right):

https://codereview.chromium.org/1267383002/diff/40001/net/url_request/certifi...
net/url_request/certificate_report_sender.cc:36: load_flags =
this can use the |= operator.

[estark, 2015-08-10 05:34:25]

estark@chromium.org changed reviewers:
+ davidben@chromium.org

[estark, 2015-08-10 05:34:26]

Thanks, Adam.

David, could you please take a look? Don't freak out at the size of this CL --
it's almost all deleting code so that we no longer special-case pin reports for
Google, as we discussed previously. I think the main real change is in
transport_security_state.cc, to load report URIs from preloaded data.

https://codereview.chromium.org/1267383002/diff/40001/net/http/transport_secu...
File net/http/transport_security_state.cc (right):

https://codereview.chromium.org/1267383002/diff/40001/net/http/transport_secu...
net/http/transport_security_state.cc:1036: if (pinset->report_uri !=
kNoReportUri)
On 2015/08/07 23:10:01, agl wrote:
> Will need to be kNoReportURI since I changed the capitalisation to meet my
own,
> selfish desires for Go style I'm afraid.

Done.

https://codereview.chromium.org/1267383002/diff/40001/net/url_request/certifi...
File net/url_request/certificate_report_sender.cc (right):

https://codereview.chromium.org/1267383002/diff/40001/net/url_request/certifi...
net/url_request/certificate_report_sender.cc:36: load_flags =
On 2015/08/07 23:10:01, agl wrote:
> this can use the |= operator.

Done.

[davidben, 2015-08-10 21:27:00]

Yay deleting code! lgtm

[estark, 2015-08-10 22:06:10]

estark@chromium.org changed reviewers:
+ mmenke@chromium.org

[estark, 2015-08-10 22:06:11]

Thanks, David.

mmenke: could you please review chrome/browser/profiles? (This CL is deleting
FraudulentCertificateReporter and its implementation in Chrome, in favor of
using the HPKP violation reporting code path.)

[mmenke, 2015-08-11 15:21:12]

On 2015/08/10 22:06:11, estark wrote:
> Thanks, David.
> 
> mmenke: could you please review chrome/browser/profiles? (This CL is deleting
> FraudulentCertificateReporter and its implementation in Chrome, in favor of
> using the HPKP violation reporting code path.)

profiles/ LGTM.  Could you update the description to make it clear this also
removes the FraudulentCertificateReporter, as opposed to just removing the need
for it?

[estark, 2015-08-11 16:51:58]

On 2015/08/11 15:21:12, mmenke wrote:
> On 2015/08/10 22:06:11, estark wrote:
> > Thanks, David.
> > 
> > mmenke: could you please review chrome/browser/profiles? (This CL is
deleting
> > FraudulentCertificateReporter and its implementation in Chrome, in favor of
> > using the HPKP violation reporting code path.)
> 
> profiles/ LGTM.  Could you update the description to make it clear this also
> removes the FraudulentCertificateReporter, as opposed to just removing the
need
> for it?

Thanks. Done.

[estark, 2015-08-11 16:52:45]

The CQ bit was checked by estark@chromium.org

[estark, 2015-08-11 16:52:45]

The patchset sent to the CQ was uploaded after l-g-t-m from agl@chromium.org
Link to the patchset: https://codereview.chromium.org/1267383002/#ps100001
(title: "rebase fixup")

[commit-bot: I haz the power, 2015-08-11 16:53:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1267383002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1267383002/100001

[commit-bot: I haz the power, 2015-08-11 18:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 18:26:04]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[estark, 2015-08-12 00:24:52]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2015-08-12 00:25:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1267383002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1267383002/100001

[commit-bot: I haz the power, 2015-08-12 02:35:57]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-08-12 02:36:43]

Patchset 6 (id:??) landed as
https://crrev.com/db949c345a8c561f45a2351daa06dc9c85671e88
Cr-Commit-Position: refs/heads/master@{#342967}