net/http/transport_security_state_static.h - Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/transport_security_state_static.h

Issue 1267383002: Allow preloaded pins to contain report URIs; remove special-case reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase fixup Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/transport_security_state_static.h

diff --git a/net/http/transport_security_state_static.h b/net/http/transport_security_state_static.h

index 0a06a032f9dadfdf7538c47f6eb8aec33a0294c6..40ba72e87ef52e6a73ce0121c18287810790c6a1 100644

--- a/net/http/transport_security_state_static.h

+++ b/net/http/transport_security_state_static.h

@@ -551,6 +551,7 @@ static const char* const kGoogleAcceptableCerts[] = {

kSPKIHash_GeoTrustGlobal,

NULL,

};

+static const char kGoogleReportURI[] = "http://clients3.google.com/cert_upload_json";

static const char* const kTorAcceptableCerts[] = {

kSPKIHash_RapidSSL,

kSPKIHash_DigiCertEVRoot,

@@ -674,7 +675,7 @@ struct Pinset {

static const struct Pinset kPinsets[] = {

{kTestAcceptableCerts, kNoRejectedPublicKeys, kNoReportURI},

- {kGoogleAcceptableCerts, kNoRejectedPublicKeys, kNoReportURI},

+ {kGoogleAcceptableCerts, kNoRejectedPublicKeys, kGoogleReportURI},

{kTorAcceptableCerts, kNoRejectedPublicKeys, kNoReportURI},

{kTwitterComAcceptableCerts, kNoRejectedPublicKeys, kNoReportURI},

{kTwitterCDNAcceptableCerts, kNoRejectedPublicKeys, kNoReportURI},

« no previous file with comments | « net/http/transport_security_state.cc ('k') | net/http/transport_security_state_static.json » ('j') | no next file with comments »