PopupMenuImpl should get menu items via PopupMenuClient.

Source/web/ExternalPopupMenuTest.cpp

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "web/ExternalPopupMenu.h"
 
 #include "core/HTMLNames.h"
 #include "core/dom/NodeComputedStyle.h"
 #include "core/frame/FrameHost.h"
@@ skipping 18 matching lines @@
 
 class TestPopupMenuClient : public PopupMenuClient {
 public:
     TestPopupMenuClient() { }
     ~TestPopupMenuClient() override { }
 
     void valueChanged(unsigned listIndex, bool fireEvents = true) override { }
     void selectionChanged(unsigned listIndex, bool fireEvents = true) override { }
     void selectionCleared() override { }
 
+    Element& itemElement(unsigned listIndex) const override { return *m_ownerElement->listItems()[listIndex]; }
     String itemText(unsigned listIndex) const override { return emptyString(); }
     String itemToolTip(unsigned listIndex) const override { return emptyString(); }
     String itemAccessibilityText(unsigned listIndex) const override { return emptyString(); }
     bool itemIsEnabled(unsigned listIndex) const override { return true; }
     LayoutUnit clientPaddingLeft() const override { return 0; }
     LayoutUnit clientPaddingRight() const override { return 0; }
     int listSize() const override { return m_ownerElement->listItems().size(); }
     int selectedIndex() const override { return 0; }
     void popupDidHide() override { }
     void popupDidCancel() override { }
     bool itemIsSeparator(unsigned listIndex) const override { return false;}
     bool itemIsLabel(unsigned listIndex) const override { return false; }
     bool itemIsSelected(unsigned listIndex) const override { return listIndex == 0;}
     bool itemIsDisplayNone(unsigned listIndex) const override { return computedStyleForItem(listIndex)->display() == NONE; }
     void provisionalSelectionChanged(unsigned listIndex) override { }
     bool multiple() const override { return false; }
     IntRect elementRectRelativeToViewport() const override { return IntRect(); }
     Element& ownerElement() const override { return *m_ownerElement; }
-    const ComputedStyle* computedStyleForItem(Element& element) const override { return nullptr; }
     const ComputedStyle* computedStyleForItem(unsigned listIndex) const override
     {
         Element* element = m_ownerElement->listItems()[listIndex];
         return element->computedStyle() ? element->computedStyle() : element->ensureComputedStyle();
     }
 
     void setOwnerElement(PassRefPtrWillBeRawPtr<HTMLSelectElement> element) { m_ownerElement = element; }
 
 private:
     RefPtrWillBePersistent<HTMLSelectElement> m_ownerElement;
@@ skipping 184 matching lines @@
     ASSERT_TRUE(menuList->popupIsVisible());
 
     WebExternalPopupMenuClient* client = static_cast<ExternalPopupMenu*>(menuList->popup());
     WebVector<int> indices;
     client->didAcceptIndices(indices);
     EXPECT_FALSE(menuList->popupIsVisible());
     EXPECT_EQ(-1, select->selectedIndex());
 }
 
 } // namespace blink