Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 12670015: Revert 146672 "Add client callbacks to notify of changes of asso..." (Closed)

Created:
7 years, 9 months ago by kareng
Modified:
7 years, 9 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1453/
Visibility:
Public.

Description

Revert 146672 "Add client callbacks to notify of changes of asso..." > Add client callbacks to notify of changes of associated from controls > https://bugs.webkit.org/show_bug.cgi?id=110375 > > Patch by Dane Wallinga <dgwallinga@chromium.org>; on 2013-03-22 > Reviewed by Ryosuke Niwa. > > Source/WebCore: > > Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded. > Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields > are dynamically created, autofill can know to re-query the autofill server and keep going. > https://bugs.webkit.org/show_bug.cgi?id=110375 > > * dom/Document.cpp: > (WebCore::Document::Document): > (WebCore::Document::didAssociateFormControl): > (WebCore): > (WebCore::Document::didAssociateFormControlsTimerFired): > * dom/Document.h: > (Document): > added method didAssociateFormControl, which batches form changes > and calls out to ChromeClient on a timer. > * html/FormAssociatedElement.cpp: > (WebCore::FormAssociatedElement::resetFormOwner): > (WebCore::FormAssociatedElement::formAttributeChanged): > (WebCore): > * html/FormAssociatedElement.h: > (FormAssociatedElement): > add calls to Document::didAssociateFormControl when form changes > * html/HTMLFormElement.cpp: > (WebCore::HTMLFormElement::insertedInto): > (WebCore): > * html/HTMLFormElement.h: > add call to Document::didAssociateFormControl > * loader/EmptyClients.h: > (EmptyChromeClient): > (WebCore::EmptyChromeClient::didAssociateFormControls): > (WebCore::EmptyChromeClient::shouldNotifyOnFormChanges): > * page/ChromeClient.h: > (ChromeClient): > add new method didAssociateFormControls > > Source/WebKit/chromium: > > Implement form association methods of ChromeClient > to inform autofill of form changes after a page has loaded > > * public/WebAutofillClient.h: > (WebAutofillClient): > (WebKit::WebAutofillClient::didAssociateInput): > (WebKit::WebAutofillClient::didAddForm): > (WebKit::WebAutofillClient::didAssociateFormControls): > * src/ChromeClientImpl.cpp: > (WebKit::ChromeClientImpl::didAssociateFormControls): > (WebKit): > (WebKit::ChromeClientImpl::shouldNotifyOnFormChanges): > * src/ChromeClientImpl.h: > (ChromeClientImpl): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M Source/WebCore/dom/Document.h View 4 chunks +0 lines, -9 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 2 chunks +0 lines, -23 lines 0 comments Download
M Source/WebCore/html/FormAssociatedElement.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/html/HTMLFormElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/loader/EmptyClients.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/page/ChromeClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/public/WebAutofillClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.cpp View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years, 9 months ago (2013-03-26 19:39:33 UTC) #1
kareng
7 years, 9 months ago (2013-03-26 19:39:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r146919.

Powered by Google App Engine
This is Rietveld 408576698