Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1266963002: Correctly construct ("file", "", 0) SecurityOrigins. (Closed)

Created:
5 years, 4 months ago by Mike West
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@plugin
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Correctly construct ("file", "", 0) SecurityOrigins. This allows us to round-trip "file://" origins through url::Origin and WebSecurityOrigin without data loss. BUG=515797 R=nasko@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199843

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M Source/platform/weborigin/SecurityOrigin.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/weborigin/SecurityOriginTest.cpp View 1 chunk +23 lines, -0 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 8 (1 generated)
Mike West
Jochen, Nasko, mind taking a look? -mike
5 years, 4 months ago (2015-07-31 08:09:08 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1266963002/diff/1/Source/platform/weborigin/SecurityOriginTest.cpp File Source/platform/weborigin/SecurityOriginTest.cpp (right): https://codereview.chromium.org/1266963002/diff/1/Source/platform/weborigin/SecurityOriginTest.cpp#newcode378 Source/platform/weborigin/SecurityOriginTest.cpp:378: {"file", "example.com", 0, "file://"}, Hm, file: can have a ...
5 years, 4 months ago (2015-07-31 08:15:01 UTC) #2
Mike West
https://codereview.chromium.org/1266963002/diff/1/Source/platform/weborigin/SecurityOriginTest.cpp File Source/platform/weborigin/SecurityOriginTest.cpp (right): https://codereview.chromium.org/1266963002/diff/1/Source/platform/weborigin/SecurityOriginTest.cpp#newcode378 Source/platform/weborigin/SecurityOriginTest.cpp:378: {"file", "example.com", 0, "file://"}, On 2015/07/31 at 08:15:01, jochen ...
5 years, 4 months ago (2015-07-31 15:21:27 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-31 15:47:01 UTC) #4
nasko
LGTM
5 years, 4 months ago (2015-07-31 15:54:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266963002/1
5 years, 4 months ago (2015-07-31 15:54:46 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 15:58:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199843

Powered by Google App Engine
This is Rietveld 408576698