Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1265953002: Appease jschuh@ by adding a setting to move 'plugin' to blockable mixed content. (Closed)

Created:
5 years, 4 months ago by Mike West
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Appease jschuh@ by adding a setting to move 'plugin' to blockable mixed content. BUG=513163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M Source/core/frame/Settings.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/MixedContentChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 3 chunks +9 lines, -4 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1266963002 Patch 1

Messages

Total messages: 8 (3 generated)
Mike West
Hi, Justin.
5 years, 4 months ago (2015-07-30 13:34:40 UTC) #2
Mike West
Jochen, mind taking a look?
5 years, 4 months ago (2015-07-31 07:09:49 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-31 13:56:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265953002/1
5 years, 4 months ago (2015-07-31 14:37:18 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 15:41:43 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199842

Powered by Google App Engine
This is Rietveld 408576698