Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1266923005: Remove a few more remnants of the internal remoting plugin. (Closed)

Created:
5 years, 4 months ago by davidben
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a few more remnants of the internal remoting plugin. BUG=510271 Committed: https://crrev.com/7776f2bce4099de007033efa1fa5f01a4d9d137b Cr-Commit-Position: refs/heads/master@{#341908}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -6 lines 2 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
davidben
Noticed this while I was poking around. Am I correct that these should also go? ...
5 years, 4 months ago (2015-08-04 23:23:25 UTC) #2
Sergey Ulanov
LGTM. Thanks!
5 years, 4 months ago (2015-08-04 23:31:48 UTC) #3
davidben
+dpranke for OWNERS
5 years, 4 months ago (2015-08-04 23:37:33 UTC) #5
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-05 02:15:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266923005/1
5 years, 4 months ago (2015-08-05 14:37:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 16:07:15 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 16:08:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7776f2bce4099de007033efa1fa5f01a4d9d137b
Cr-Commit-Position: refs/heads/master@{#341908}

Powered by Google App Engine
This is Rietveld 408576698