Issue 1266863002: Subzero. Misc X86 fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1266863002: Subzero. Misc X86 fixes. (Closed)

Created:
5 years, 4 months ago by John

Modified:
5 years, 4 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero. Misc fixes. This CL disables the X86 assembler tests by default. They take too long to compile, so there's very little point in running them with the other unittests. This CL fixes a bug introduced in https://codereview.chromium.org/1260163003/ that caused liveness analysis to assert due to a uninitialized Variable. BUG= R=jvoung@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=59f2d925252faa7ae7cc688cfdfcf7c4a6f62cce

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	Makefile.standalone	View		2 chunks	+7 lines, -3 lines	0 comments	Download
	M	src/IceTargetLoweringX86BaseImpl.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

Jim Stichnoth

LGTM, but it would be nice to make sure there's a lit test for each ...

5 years, 4 months ago (2015-07-30 19:30:21 UTC) #4

John

5 years, 4 months ago (2015-07-31 20:45:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
59f2d925252faa7ae7cc688cfdfcf7c4a6f62cce (presubmit successful).