Fix for crash in testWindows test

android_webview/browser/browser_view_renderer_impl.cc

Index: android_webview/browser/browser_view_renderer_impl.cc
diff --git a/android_webview/browser/browser_view_renderer_impl.cc b/android_webview/browser/browser_view_renderer_impl.cc
index ef1f9d189e24e90545a8e54f00b0ecb25fe7c868..daa48b517d0abd8931f69ac9a50056b607046c53 100644
--- a/android_webview/browser/browser_view_renderer_impl.cc
+++ b/android_webview/browser/browser_view_renderer_impl.cc
@@ -158,15 +158,7 @@ void BrowserViewRendererImpl::SetAwDrawSWFunctionTable(
 }
 
 void BrowserViewRendererImpl::SetContents(ContentViewCore* content_view_core) {
-  if (web_contents_) {
-    ContentViewCore* previous_content_view_core =
-        ContentViewCore::FromWebContents(web_contents_);
-    if (previous_content_view_core) {
-      previous_content_view_core->RemoveFrameInfoCallback(
-          update_frame_info_callback_);
-    }
-  }
-
+  // TODO(joth): Allowing a NULL param is probably not needed, see b/8341990

[Leandro Graciá Gil, 2013/03/08 11:46:56]

The destructor is calling with a NULL param to release any previously registered
callback. If I remember correctly this was actually one of your review
suggestions. Also, this workaround would prevent removing any frame metadata
update callbacks from old ContentViewCores. Are you sure this is the right way
to do this?

   web_contents_ = content_view_core ?
                   content_view_core->GetWebContents() : NULL;
   view_renderer_host_->Observe(web_contents_);