Fix for crash in testWindows test

android_webview/browser/browser_view_renderer_impl.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/browser_view_renderer_impl.h"
 
 #include <android/bitmap.h>
 #include <sys/system_properties.h>
 
 #include "android_webview/common/renderer_picture_map.h"
@@ skipping 140 matching lines @@
 void BrowserViewRendererImpl::SetAwDrawSWFunctionTable(
     AwDrawSWFunctionTable* table) {
   g_sw_draw_functions = table;
   g_is_skia_version_compatible =
       g_sw_draw_functions->is_skia_version_compatible(&SkGraphics::GetVersion);
   LOG_IF(WARNING, !g_is_skia_version_compatible)
       << "Skia versions are not compatible, rendering performance will suffer.";
 }
 
 void BrowserViewRendererImpl::SetContents(ContentViewCore* content_view_core) {
-  if (web_contents_) {
-    ContentViewCore* previous_content_view_core =
-        ContentViewCore::FromWebContents(web_contents_);
-    if (previous_content_view_core) {
-      previous_content_view_core->RemoveFrameInfoCallback(
-          update_frame_info_callback_);
-    }
-  }
-
+  // TODO(joth): Allowing a NULL param is probably not needed, see b/8341990

[Leandro Graciá Gil, 2013/03/08 11:46:56]

The destructor is calling with a NULL param to release any previously registered
callback. If I remember correctly this was actually one of your review
suggestions. Also, this workaround would prevent removing any frame metadata
update callbacks from old ContentViewCores. Are you sure this is the right way
to do this?

   web_contents_ = content_view_core ?
                   content_view_core->GetWebContents() : NULL;
   view_renderer_host_->Observe(web_contents_);
 
   if (!content_view_core)
     return;
 
   content_view_core->AddFrameInfoCallback(update_frame_info_callback_);
   dpi_scale_ = content_view_core->GetDpiScale();
 
@@ skipping 447 matching lines @@
 
 void BrowserViewRendererImpl::OnFrameInfoUpdated(
     const gfx::SizeF& content_size,
     const gfx::Vector2dF& scroll_offset,
     float page_scale_factor) {
   page_scale_ = page_scale_factor;
   content_size_css_ = content_size;
 }
 
 }  // namespace android_webview