Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1266773003: Implement support for dual source blending in ES (Closed)

Created:
5 years, 4 months ago by Kimmo Kinnunen
Modified:
5 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Implement support for dual source blending in ES Use EXT_blend_func_extended to implement dual source blending in OpenGL ES. The extension is the ES version of ARB_blend_func_extended. The extension provides gl_SecondaryFragColorEXT for ES 2.0 contexts. The extension provides glBindFragDataLocationIndexed to bind a custom fragment shader output to the secondary color for ES 3.0 contexts. For ES 3.1 contexts, the extension would also give "layout (location=0, index=1)" output varible layout modifier syntax, but it is not used in this patch. The extension needs #extension GL_EXT_blend_func_extended : require directive for the variables to be available in ES 2.0. For ES 3.0, the directive relaxes the rules for the amount of output variables without layout location qualifiers. OpenGL continues to use GL_ARB_blend_func_extended for dual source blending. Committed: https://skia.googlesource.com/skia/+/d94708e71e8611015cdeb4f5874a11816e40ecdc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -14 lines) Patch
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +13 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 4 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Kimmo Kinnunen
Not that critical time-wise, since there's no other driver implementation available except my command buffer ...
5 years, 4 months ago (2015-07-30 13:11:25 UTC) #2
bsalomon
On 2015/07/30 13:11:25, Kimmo Kinnunen wrote: > Not that critical time-wise, since there's no other ...
5 years, 4 months ago (2015-07-30 14:07:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266773003/1
5 years, 4 months ago (2015-07-31 05:38:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d94708e71e8611015cdeb4f5874a11816e40ecdc
5 years, 4 months ago (2015-07-31 05:47:06 UTC) #6
Kimmo Kinnunen
So this fails Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug with some GL errors: http://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug/builds/807 I have hard time reproing it ...
5 years, 4 months ago (2015-07-31 12:53:40 UTC) #7
Kimmo Kinnunen
5 years, 4 months ago (2015-07-31 12:55:51 UTC) #8
Message was sent while issue was closed.
On 2015/07/31 12:53:40, Kimmo Kinnunen wrote:
> So this fails Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug with some GL
> errors:
>
http://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Gal...
> 
> I have hard time reproing it with a local S3 Mali400, and hard time
> understanding why the patch would affect the device.. Still, maybe revert is
in
> order..

N/M: skbug.com/3947

Powered by Google App Engine
This is Rietveld 408576698