Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1266723002: Revert of [Chromecast] Change chromecast_branding to public (Closed)

Created:
5 years, 4 months ago by yucliu1
Modified:
5 years, 4 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromecast] Change chromecast_branding to public (patchset #6 id:100001 of https://codereview.chromium.org/1262673004/) Reason for revert: Revert the CL temporary for TOT build. Checked in again once the internal CLs are approved. Original issue's description: > [Chromecast] Change chromecast_branding to public > > Change chromecast_branding from Chrome/Chromium to > public/internal/google in gyp file. "public" is the same as "Chromium" > and the other two are considered as "Chrome". > > BUG= > > Committed: https://crrev.com/0f46bd94566380a99ecda0753f659b7e114e3d3d > Cr-Commit-Position: refs/heads/master@{#341016} TBR=lcwu@chromium.org,gunsch@chromium.org,byungchul@chromium.org,slan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/cc83429750aac56eef9068fcd617d4474d310960 Cr-Commit-Position: refs/heads/master@{#341034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M chromecast/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/chromecast.gni View 1 chunk +2 lines, -4 lines 0 comments Download
M chromecast/chromecast.gyp View 6 chunks +6 lines, -6 lines 0 comments Download
M chromecast/chromecast_locales.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/chromecast_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/media/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/media.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M chromecast/tools/build/chromecast_repack_locales.py View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
yucliu1
Created Revert of [Chromecast] Change chromecast_branding to public
5 years, 4 months ago (2015-07-30 00:33:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266723002/1
5 years, 4 months ago (2015-07-30 00:35:11 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-07-30 00:35:13 UTC) #4
gunsch-google
lgtm lgtm
5 years, 4 months ago (2015-07-30 00:36:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266723002/1
5 years, 4 months ago (2015-07-30 00:37:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 00:38:35 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cc83429750aac56eef9068fcd617d4474d310960 Cr-Commit-Position: refs/heads/master@{#341034}
5 years, 4 months ago (2015-07-30 00:41:24 UTC) #10
yucliu1
5 years, 4 months ago (2015-07-30 21:01:10 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1256323009/ by yucliu@chromium.org.

The reason for reverting is: retrieve the branding change CL since internal CL
is submitted..

Powered by Google App Engine
This is Rietveld 408576698