[Intepreter] Addition of BytecodeArrayBuilder and accumulator based bytecodes.

src/objects.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <iomanip>
 #include <sstream>
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
@@ skipping 11593 matching lines @@
     it.rinfo()->Print(GetIsolate(), os);
   }
   os << "\n";
 }
 #endif  // ENABLE_DISASSEMBLER
 
 
 void BytecodeArray::Disassemble(std::ostream& os) {
   os << "Frame size " << frame_size() << "\n";
   Vector<char> buf = Vector<char>::New(50);
   int bytes = 0;

[picksi, 2015/08/03 11:06:01]

Can we name 'bytes' to say what this is (the size of a bytecode+params, the size
of a function?)? It is not clear!

[oth, 2015/08/03 15:39:59]

Reworked in https://codereview.chromium.org/1259193004

   for (int i = 0; i < this->length(); i += bytes) {
     interpreter::Bytecode bytecode = interpreter::Bytecodes::FromByte(get(i));
     bytes = interpreter::Bytecodes::Size(bytecode);
-
     SNPrintF(buf, "%p : ", GetFirstBytecodeAddress() + i);
     os << buf.start();
     for (int j = 0; j < bytes; j++) {
       SNPrintF(buf, "%02x ", get(i + j));
       os << buf.start();
     }
     for (int j = bytes; j < interpreter::Bytecodes::MaximumSize(); j++) {
       os << "   ";
     }
-    os << bytecode << "\n";
+    os << bytecode << " ";
+    for (int j = 1; j < bytes; j++) {

[picksi, 2015/08/03 11:06:01]

Should this for-loop be pulled out into a separate function? It looks to be
conceptually at a lower level (disassembling a single instruction?).

Also, the value of 'j' is used as j-1, j and j+1. Is there a way to rework this
to not need some many variations!

[oth, 2015/08/03 15:39:59]

Reworked in https://codereview.chromium.org/1259193004.

+      interpreter::OperandType op_type =
+          interpreter::Bytecodes::GetOperandType(bytecode, j - 1);
+      uint8_t operand = get(i + j);
+      switch (op_type) {
+        case interpreter::OperandType::kImm8:
+          os << "#" << static_cast<int>(operand);
+          break;
+        case interpreter::OperandType::kReg:
+          os << "r" << static_cast<int>(operand);
+          break;
+        case interpreter::OperandType::kNone:
+          UNREACHABLE();
+          break;
+      }
+      if (j + 1 < bytes) {
+        os << ", ";
+      }
+    }
+    os << "\n";
   }
 }
 
 
 // static
 void JSArray::Initialize(Handle<JSArray> array, int capacity, int length) {
   DCHECK(capacity >= 0);
   array->GetIsolate()->factory()->NewJSArrayStorage(
       array, length, capacity, INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE);
 }
@@ skipping 4133 matching lines @@
   if (cell->value() != *new_value) {
     cell->set_value(*new_value);
     Isolate* isolate = cell->GetIsolate();
     cell->dependent_code()->DeoptimizeDependentCodeGroup(
         isolate, DependentCode::kPropertyCellChangedGroup);
   }
 }
 
 }  // namespace internal
 }  // namespace v8