[Interpreter] Consistency fixes.

[Interpreter] Consistency fixes.

Change minimum BytecodeArray frame size to zero now return value is in
the accumulator.

Fix inconsistent checks in bytecode-array-builder.cc.

Simplify bytecode disassembly by adding Bytecodes::Decode to
disassemble one bytecode and operands.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/d689c7a7be90c01d13d87f6cf0281ceae1f5f813
Cr-Commit-Position: refs/heads/master@{#29988}

[oth, 2015-08-03 15:45:41]

oth@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[oth, 2015-08-03 15:45:42]

mstarzinger PTAL - this is minor clean-up.

picksi - this change attempts to incorporate your comments from
https://codereview.chromium.org/1266713004/.

Thanks!

[oth, 2015-08-03 15:46:00]

The CQ bit was checked by oth@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-03 15:46:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1259193004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1259193004/1

[commit-bot: I haz the power, 2015-08-03 15:46:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 15:46:27]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Michael Starzinger, 2015-08-03 15:59:09]

LGTM with one optional suggestion.

https://codereview.chromium.org/1259193004/diff/1/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/1259193004/diff/1/src/interpreter/bytecodes.h...
src/interpreter/bytecodes.h:104: const uint8_t* bytecode_end);
It looks like the {bytecode_end} argument is only used for checking, and we
could do without it. I am fine with leaving it as it is if you think the
interface makes more sense that way. Up to you.

[oth, 2015-08-03 16:16:06]

The CQ bit was checked by oth@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-03 16:16:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1259193004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1259193004/20001

[oth, 2015-08-03 16:17:21]

On 2015/08/03 15:59:09, Michael Starzinger wrote:
> LGTM with one optional suggestion.
> 
> https://codereview.chromium.org/1259193004/diff/1/src/interpreter/bytecodes.h
> File src/interpreter/bytecodes.h (right):
> 
>
https://codereview.chromium.org/1259193004/diff/1/src/interpreter/bytecodes.h...
> src/interpreter/bytecodes.h:104: const uint8_t* bytecode_end);
> It looks like the {bytecode_end} argument is only used for checking, and we
> could do without it. I am fine with leaving it as it is if you think the
> interface makes more sense that way. Up to you.

Thanks Michael. Pruned this, it was redundant and not telling us anything
useful.

[commit-bot: I haz the power, 2015-08-03 16:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 16:41:32]

Dry run: This issue passed the CQ dry run.

[picksi, 2015-08-03 17:13:32]

Thanks! These changes work well.

[oth, 2015-08-03 20:36:49]

The CQ bit was checked by oth@chromium.org

[oth, 2015-08-03 20:36:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1259193004/#ps20001
(title: "Remove redundant argument to Bytecodes::Decode().")

[commit-bot: I haz the power, 2015-08-03 20:36:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1259193004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1259193004/20001

[commit-bot: I haz the power, 2015-08-03 20:39:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-03 20:39:42]

Patchset 2 (id:??) landed as
https://crrev.com/d689c7a7be90c01d13d87f6cf0281ceae1f5f813
Cr-Commit-Position: refs/heads/master@{#29988}