ApplicationImpl cleanup, part 1:

ApplicationImpl cleanup, part 1:
- Remove ctor that does not take a termination closure.
- Terminate()->Quit()
- QuitNow()->private

R=jam@chromium.org
BUG=none

Committed: https://crrev.com/46e34f6bc1c8424c383776e5961094c5df5d563b
Cr-Commit-Position: refs/heads/master@{#341028}

Committed: https://crrev.com/c688d2ebd66cb1fc7d85c478d3858329fbc194b3
Cr-Commit-Position: refs/heads/master@{#342676}

[Ben Goodger (Google), 2015-07-29 19:16:34]

https://codereview.chromium.org/1266643003/diff/1/components/filesystem/file_...
File components/filesystem/file_system_app.cc (right):

https://codereview.chromium.org/1266643003/diff/1/components/filesystem/file_...
components/filesystem/file_system_app.cc:70: app_->Quit();
Since the shell connection is already severed, Quit() just calls through to
QuitNow().

[jam, 2015-07-29 20:15:21]

lgtm

[Ben Goodger (Google), 2015-07-29 22:51:01]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-07-29 22:51:01]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1266643003/#ps60001
(title: ".")

[commit-bot: I haz the power, 2015-07-29 22:51:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1266643003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1266643003/60001

[commit-bot: I haz the power, 2015-07-30 00:03:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-30 00:04:17]

Patchset 4 (id:??) landed as
https://crrev.com/46e34f6bc1c8424c383776e5961094c5df5d563b
Cr-Commit-Position: refs/heads/master@{#341028}

[Lei Zhang, 2015-07-30 00:35:57]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-07-30 00:35:57]

Looks like you missed the pdf viewer component:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/buil...

[dzhioev (left Google), 2015-07-30 01:54:30]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1257703003/ by dzhioev@chromium.org.

The reason for reverting is: Breaks Linux build:
[1240/8599] CXX obj/components/pdf_viewer/libpdf_viewer_library/pdf_viewer.o
FAILED: /mnt/data/b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/components/pdf_viewer/libpdf_viewer_library/pdf_viewer.o.d
-DGL_GLEXT_PROTOTYPES -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1
-DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1
-DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA -DUSE_UDEV
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1
-DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1
-DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1
-DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1
-DENABLE_TOPCHROME_MD=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1
-DENABLE_PRE_SYNC_BACKUP -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD
-DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=242792-1 -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-DGL_GLEXT_PROTOTYPES -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS
-DSK_LEGACY_SKPOINT3_CTORS -DSK_SUPPORT_GPU=1 -DU_USING_ICU_NAMESPACE=0
-DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DGLES2_USE_MOJO -I../.. -Igen
-I../../third_party/mojo/src -Igen/third_party/mojo/src -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos
-I../../gpu -I../../skia/config -I../../skia/ext
-I../../third_party/skia/include/c -I../../third_party/skia/include/config
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/images -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu
-I../../third_party/skia/src/gpu -I../../third_party/icu/source/common
-I../../third_party/icu/source/i18n -I../../mojo/services -Igen/mojo/services
-fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64
-march=x86-64 -funwind-tables -fPIC -pipe -pthread
-B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -Wall
-Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal
-Wno-inconsistent-missing-override -Wno-shift-negative-value -fvisibility=hidden
-Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin
-Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O2 -fno-ident
-fdata-sections -ffunction-sections -g1 -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c
../../components/pdf_viewer/pdf_viewer.cc -o
obj/components/pdf_viewer/libpdf_viewer_library/pdf_viewer.o
../../components/pdf_viewer/pdf_viewer.cc:435:12: error: no member named
'Terminate' in 'mojo::ApplicationImpl'
      app_.Terminate();
      ~~~~ ^
1 error generated.
ninja: build stopped: subcommand failed..

[Ben Goodger (Google), 2015-08-10 17:54:14]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-08-10 17:54:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1266643003/#ps80001
(title: ".")

[commit-bot: I haz the power, 2015-08-10 17:54:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1266643003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1266643003/80001

[commit-bot: I haz the power, 2015-08-10 19:35:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-10 19:36:54]

Patchset 5 (id:??) landed as
https://crrev.com/c688d2ebd66cb1fc7d85c478d3858329fbc194b3
Cr-Commit-Position: refs/heads/master@{#342676}