mojo/application/public/cpp/lib/app_lifetime_helper.cc - Issue 1266643003: ApplicationImpl cleanup, part 1:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/application/public/cpp/lib/app_lifetime_helper.cc

Issue 1266643003: ApplicationImpl cleanup, part 1: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/application/public/cpp/lib/app_lifetime_helper.cc

diff --git a/mojo/application/public/cpp/lib/app_lifetime_helper.cc b/mojo/application/public/cpp/lib/app_lifetime_helper.cc

index 4d12339138056b4b39172699a7ca41074b9d816c..74c7ee86ecd61b85b72cff874ec16e51a7b9fddc 100644

--- a/mojo/application/public/cpp/lib/app_lifetime_helper.cc

+++ b/mojo/application/public/cpp/lib/app_lifetime_helper.cc

@@ -83,11 +83,11 @@ void AppLifetimeHelper::AddRef() {

void AppLifetimeHelper::Release() {

if (!--ref_count_) {

if (app_)

- app_->Terminate();

+ app_->Quit();

}

-void AppLifetimeHelper::ApplicationTerminated() {

+void AppLifetimeHelper::OnQuit() {

app_ = nullptr;

}