src/effects/SkLightingShader.cpp - Issue 1266633003: Added registerChild; transforms, textures, glKey automatically handled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingShader.cpp

Issue 1266633003: Added registerChild; transforms, textures, glKey automatically handled. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: refactored to onGetGLProcessorKey; removed emitSamplers specialized template; fixed nits Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkLightingShader.cpp

diff --git a/src/effects/SkLightingShader.cpp b/src/effects/SkLightingShader.cpp

index 4dcfa527f90f7c2dc92458262647808f6dddd09a..6ed98746397cfcfb5d193d6281b9d543cb0a911c 100644

--- a/src/effects/SkLightingShader.cpp

+++ b/src/effects/SkLightingShader.cpp

@@ -227,7 +227,7 @@ public:

GrGLFragmentProcessor* createGLInstance() const override { return SkNEW(LightingGLFP); }

- void getGLProcessorKey(const GrGLSLCaps& caps, GrProcessorKeyBuilder* b) const override {

+ void onGetGLProcessorKey(const GrGLSLCaps& caps, GrProcessorKeyBuilder* b) const override {

LightingGLFP::GenKey(*this, caps, b);

}

« no previous file with comments | « src/effects/SkLightingImageFilter.cpp ('k') | src/effects/SkLumaColorFilter.cpp » ('j') | no next file with comments »