Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1266623002: Impose max running time for apptests. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Impose max running time for apptests. Fixes domokit/devtools#11. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2b0afa8009aeb16304edff99d41a279f748aba54

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Indicate time unit when printing out the time out value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -36 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 1 chunk +31 lines, -11 lines 0 comments Download
M mojo/devtools/common/devtoolslib/apptest.py View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M mojo/devtools/common/devtoolslib/apptest_dart.py View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/devtools/common/devtoolslib/apptest_gtest.py View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/devtools/common/devtoolslib/linux_shell.py View 2 chunks +29 lines, -7 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell.py View 1 chunk +8 lines, -4 lines 0 comments Download
M mojo/devtools/common/mojo_test View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-07-29 17:22:57 UTC) #1
qsr
lgtm
5 years, 4 months ago (2015-07-30 09:57:55 UTC) #2
ppi
5 years, 4 months ago (2015-07-30 11:14:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2b0afa8009aeb16304edff99d41a279f748aba54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698