Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: mojo/devtools/common/devtoolslib/apptest_dart.py

Issue 1266623002: Impose max running time for apptests. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Indicate time unit when printing out the time out value. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/devtools/common/devtoolslib/apptest.py ('k') | mojo/devtools/common/devtoolslib/apptest_gtest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/apptest_dart.py
diff --git a/mojo/devtools/common/devtoolslib/apptest_dart.py b/mojo/devtools/common/devtoolslib/apptest_dart.py
index 06c329ec450e0f16c50cc8a06d3c7b9527712dec..fe6131f8ac085a6dacf6d38e60a52632d69cfb23 100644
--- a/mojo/devtools/common/devtoolslib/apptest_dart.py
+++ b/mojo/devtools/common/devtoolslib/apptest_dart.py
@@ -14,12 +14,13 @@ from devtoolslib.apptest import run_apptest
SUCCESS_PATTERN = re.compile('^.+ .+: All tests passed!', re.MULTILINE)
+
def _dart_apptest_output_test(output):
- return SUCCESS_PATTERN.search(output) != None
+ return SUCCESS_PATTERN.search(output) is not None
# TODO(erg): Support android, launched services and fixture isolation.
-def run_dart_apptest(shell, shell_args, apptest_url, apptest_args):
+def run_dart_apptest(shell, shell_args, apptest_url, apptest_args, timeout):
"""Runs a dart apptest.
Args:
@@ -30,5 +31,5 @@ def run_dart_apptest(shell, shell_args, apptest_url, apptest_args):
Returns:
True iff the test succeeded, False otherwise.
"""
- return run_apptest(shell, shell_args, apptest_url, apptest_args,
+ return run_apptest(shell, shell_args, apptest_url, apptest_args, timeout,
_dart_apptest_output_test)
« no previous file with comments | « mojo/devtools/common/devtoolslib/apptest.py ('k') | mojo/devtools/common/devtoolslib/apptest_gtest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698