Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1266573003: Move final parts of class literal setup into a single runtime call (Closed)

Created:
5 years, 4 months ago by conradw
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move final parts of class literal setup into a single runtime call This avoids multiple ToFastProperties runtime calls and additional stack pushes in strong mode. BUG= Committed: https://crrev.com/c1970988c0554ebcd14926ef19652d1340f84c1e Cr-Commit-Position: refs/heads/master@{#29925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -159 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +9 lines, -18 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +6 lines, -17 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +6 lines, -17 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +6 lines, -17 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
conradw
PTAL
5 years, 4 months ago (2015-07-29 14:36:02 UTC) #2
rossberg
lgtm
5 years, 4 months ago (2015-07-30 09:55:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266573003/1
5 years, 4 months ago (2015-07-30 09:58:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 10:38:11 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 10:38:39 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c1970988c0554ebcd14926ef19652d1340f84c1e
Cr-Commit-Position: refs/heads/master@{#29925}

Powered by Google App Engine
This is Rietveld 408576698