Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1266573003: Move final parts of class literal setup into a single runtime call (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/ia32/full-codegen-ia32.cc
diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc
index 6652c92e9fd2f0a9dbdf1d48bab44a3ae11031bb..015ab2f7847a8748597a7fcd3c8d1520fe49c420 100644
--- a/src/full-codegen/ia32/full-codegen-ia32.cc
+++ b/src/full-codegen/ia32/full-codegen-ia32.cc
@@ -2483,24 +2483,12 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit,
}
}
- // prototype
- __ CallRuntime(Runtime::kToFastProperties, 1);
-
- // constructor
- __ CallRuntime(Runtime::kToFastProperties, 1);
-
- if (is_strong(language_mode())) {
- __ mov(scratch,
- FieldOperand(eax, JSFunction::kPrototypeOrInitialMapOffset));
- __ push(eax);
- __ Push(scratch);
- // TODO(conradw): It would be more efficient to define the properties with
- // the right attributes the first time round.
- // Freeze the prototype.
- __ CallRuntime(Runtime::kObjectFreeze, 1);
- // Freeze the constructor.
- __ CallRuntime(Runtime::kObjectFreeze, 1);
- }
+ // Set both the prototype and constructor to have fast properties, and also
+ // freeze them in strong mode.
+ __ CallRuntime(is_strong(language_mode())
+ ? Runtime::kFinalizeClassDefinitionStrong
+ : Runtime::kFinalizeClassDefinition,
+ 2);
}
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698