Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1266553002: Include overflow when setting the logical flowthread bottom on the last column set. (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Include overflow when setting the logical flowthread bottom on the last column set. The logical height of the flow thread may be shorter than the start flowthread offset of the last column set, if there's overflowing content. We used to have expandToEncompassFlowThreadOverflow() to correct this, but let's include overflow right away, instead of setting the bottom offset twice (first incorrectly, then correctly). This avoids an assertion failure (in this case the assertion was harmless, though). BUG=512362 R=dsinclair@chromium.org,jchaffraix@chromium.org,leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -31 lines) Patch
A + LayoutTests/fast/multicol/constrained-content-height-with-overflow-crash.html View 1 chunk +3 lines, -2 lines 0 comments Download
A + LayoutTests/fast/multicol/constrained-content-height-with-overflow-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnSet.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mstensho (USE GERRIT)
5 years, 4 months ago (2015-07-29 12:01:37 UTC) #1
mstensho (USE GERRIT)
5 years, 4 months ago (2015-08-03 08:10:20 UTC) #2
leviw_travelin_and_unemployed
lgtm
5 years, 4 months ago (2015-08-03 21:10:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266553002/1
5 years, 4 months ago (2015-08-03 21:10:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/64840)
5 years, 4 months ago (2015-08-03 23:07:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266553002/1
5 years, 4 months ago (2015-08-04 06:36:34 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 07:14:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199952

Powered by Google App Engine
This is Rietveld 408576698