Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: Source/core/layout/MultiColumnFragmentainerGroup.cpp

Issue 1266553002: Include overflow when setting the logical flowthread bottom on the last column set. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/MultiColumnFragmentainerGroup.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/MultiColumnFragmentainerGroup.cpp
diff --git a/Source/core/layout/MultiColumnFragmentainerGroup.cpp b/Source/core/layout/MultiColumnFragmentainerGroup.cpp
index abcd82192dd31de49a3ea03573d2613264d86667..65e53642f2cb84333a7ff9dd7a27c246cb39d87f 100644
--- a/Source/core/layout/MultiColumnFragmentainerGroup.cpp
+++ b/Source/core/layout/MultiColumnFragmentainerGroup.cpp
@@ -117,19 +117,6 @@ bool MultiColumnFragmentainerGroup::recalculateColumnHeight(BalancedColumnHeight
return true; // Need another pass.
}
-void MultiColumnFragmentainerGroup::expandToEncompassFlowThreadOverflow()
-{
- ASSERT(isLastGroup());
- // Get the offset within the flow thread in its block progression direction. Then get the
- // flow thread's remaining logical height including its overflow and expand our rect
- // to encompass that remaining height and overflow. The idea is that we will generate
- // additional columns and pages to hold that overflow, since people do write bad
- // content like <body style="height:0px"> in multi-column layouts.
- LayoutMultiColumnFlowThread* flowThread = m_columnSet.multiColumnFlowThread();
- LayoutRect layoutRect = flowThread->layoutOverflowRect();
- m_logicalBottomInFlowThread = flowThread->isHorizontalWritingMode() ? layoutRect.maxY() : layoutRect.maxX();
-}
-
LayoutSize MultiColumnFragmentainerGroup::flowThreadTranslationAtOffset(LayoutUnit offsetInFlowThread) const
{
LayoutFlowThread* flowThread = m_columnSet.flowThread();
« no previous file with comments | « Source/core/layout/MultiColumnFragmentainerGroup.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698