Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1266533002: export the entire HTMLResourcePreloader class in shared_library builds (Closed)

Created:
5 years, 4 months ago by Mostyn Bramley-Moore
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

export the entire HTMLResourcePreloader class in shared_library builds After https://codereview.chromium.org/1112833004/ landed, libblink_web.so fails to link in some configurations, giving this error: obj/third_party/WebKit/Source/core/html/parser/blink_web.HTMLResourcePreloaderTest.o:HTMLResourcePreloaderTest.cpp:function blink::HTMLResourcePreloaderTest::test(blink::PreconnectTestCase): error: undefined reference to 'vtable for blink::HTMLResourcePreloader' /usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function The blink::HTMLResourcePreloader vtable exists in lib/libwebcore_shared.so but only as a local symbol, because I assume that the HTMLResourcePreloader class has some un-exported virtual methods in these configuration. So we should be able to solve this by exporting the entire HTMLResourcePreloader class. Committed: https://crrev.com/8ce38a987baaa4fa4788836b8355808ec7a8e50b git-svn-id: svn://svn.chromium.org/blink/trunk@199651 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/html/parser/HTMLResourcePreloader.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mostyn Bramley-Moore
I think this fixes the link error that appeared after https://codereview.chromium.org/1112833004/ landed.
5 years, 4 months ago (2015-07-29 08:39:29 UTC) #2
Yoav Weiss
On 2015/07/29 08:39:29, Mostyn Bramley-Moore wrote: > I think this fixes the link error that ...
5 years, 4 months ago (2015-07-29 08:44:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266533002/1
5 years, 4 months ago (2015-07-29 08:50:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266533002/1
5 years, 4 months ago (2015-07-29 09:05:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199651
5 years, 4 months ago (2015-07-29 09:52:08 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:53:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ce38a987baaa4fa4788836b8355808ec7a8e50b

Powered by Google App Engine
This is Rietveld 408576698