Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 12662028: Revert 189802 "Refactor libjingle and libpeerconnection targets." (Closed)

Created:
7 years, 9 months ago by tommi (sloooow) - chröme
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 189802 "Refactor libjingle and libpeerconnection targets." For some reason the "Linux Builder (dbg)(32)" bot is failing (and not other linux bots): lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::~WebRtcVideoEngine()' lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::GetVideoCapturer() const' lib/libsync.so: undefined reference to `cricket::WebRtcVoiceEngine::RegisterProcessor(unsigned int, cricket::VoiceProcessor*, cricket::MediaProcessorDirection)' lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::SetOptions(int)' lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::Terminate() ...etc > Refactor libjingle and libpeerconnection targets. > I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set. > > I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection. > > TBR=darin > > Review URL: https://codereview.chromium.org/12457027 TBR=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -96 lines) Patch
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/third_party/libjingle/libjingle.gyp View 6 chunks +74 lines, -90 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
7 years, 9 months ago (2013-03-22 14:21:56 UTC) #1
tommi (sloooow) - chröme
7 years, 9 months ago (2013-03-22 14:22:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r189806.

Powered by Google App Engine
This is Rietveld 408576698