Refactor libjingle and libpeerconnection targets.

Refactor libjingle and libpeerconnection targets.
I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle.  The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set.

I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection.

TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189802

[tommi (sloooow) - chröme, 2013-03-17 21:53:31]

Ronghua: libjingle.gyp
Darin: chrome_browser.gypi, content_tests.gypi

[Ronghua Wu (Left Chromium), 2013-03-18 18:36:30]

https://codereview.chromium.org/12457027/diff/1/third_party/libjingle/libjing...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12457027/diff/1/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:614:
'<(DEPTH)/third_party/webrtc/modules/modules.gyp:video_capture_module',
Do we need the conditions 'enable_webrtc==1' since the webrtc modules are used.

[tommi (sloooow) - chröme, 2013-03-18 20:14:21]

https://codereview.chromium.org/12457027/diff/1/third_party/libjingle/libjing...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12457027/diff/1/third_party/libjingle/libjing...
third_party/libjingle/libjingle.gyp:614:
'<(DEPTH)/third_party/webrtc/modules/modules.gyp:video_capture_module',
On 2013/03/18 18:36:30, Ronghua Wu wrote:
> Do we need the conditions 'enable_webrtc==1' since the webrtc modules are
used.

Yes, thanks for catching that.  I've fixed it and improved the diff.

[Ronghua Wu (Left Chromium), 2013-03-18 20:52:15]

Two minor comments, libjingle.gyp LGTM otherwise.

https://codereview.chromium.org/12457027/diff/7001/third_party/libjingle/libj...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12457027/diff/7001/third_party/libjingle/libj...
third_party/libjingle/libjingle.gyp:493:
'<(DEPTH)/third_party/libsrtp/libsrtp.gyp:libsrtp',
libsrtp should be move down into enable_webrtc==1.

https://codereview.chromium.org/12457027/diff/7001/third_party/libjingle/libj...
third_party/libjingle/libjingle.gyp:784: 'target_name':
'libjingle_p2p_constants',
rename this to libjingle_p2p_base_constants to align with
libjingle_media_base_constants.

[tommi (sloooow) - chröme, 2013-03-18 21:28:23]

https://codereview.chromium.org/12457027/diff/7001/third_party/libjingle/libj...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/12457027/diff/7001/third_party/libjingle/libj...
third_party/libjingle/libjingle.gyp:493:
'<(DEPTH)/third_party/libsrtp/libsrtp.gyp:libsrtp',
On 2013/03/18 20:52:15, Ronghua Wu wrote:
> libsrtp should be move down into enable_webrtc==1.

Done.

https://codereview.chromium.org/12457027/diff/7001/third_party/libjingle/libj...
third_party/libjingle/libjingle.gyp:784: 'target_name':
'libjingle_p2p_constants',
On 2013/03/18 20:52:15, Ronghua Wu wrote:
> rename this to libjingle_p2p_base_constants to align with
> libjingle_media_base_constants.

Done.

[tommi (sloooow) - chröme, 2013-03-21 16:48:46]

Darin - ping for chrome_browser.gypi and content_tests.gypi.

[tommi (sloooow) - chröme, 2013-03-22 04:21:03]

TBR Darin for content_tests and chrome_browser changes.

[commit-bot: I haz the power, 2013-03-22 04:21:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommi@chromium.org/12457027/14001

[tommi (sloooow) - chröme, 2013-03-22 14:04:09]

Committed patchset #4 manually as r189802 (presubmit successful).

[darin (slow to review), 2013-03-23 14:28:36]

LGTM