Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: sdk/lib/developer/developer.dart

Issue 1266053003: Make dart:developer log more user friendly (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/developer/developer.dart
diff --git a/sdk/lib/developer/developer.dart b/sdk/lib/developer/developer.dart
index 06c980e7e929f833b7d6997e137103d7ddac3ef4..87cc524a18532c53b84e013745d5e459c5e64784 100644
--- a/sdk/lib/developer/developer.dart
+++ b/sdk/lib/developer/developer.dart
@@ -35,19 +35,19 @@ external bool debugger({bool when: true, String msg});
external inspect(object);
/// Emit a log event.
-/// [sequenceNumber] is a monotonically increasing sequence number.
-/// [millisececondsSinceEpoch] is a timestamp.
-/// [level] is the severity level (value between 0 and 2000 inclusive).
-/// [name] is the name of the source of the log message.
/// [message] is the log message.
+/// [time] is the timestamp.
+/// [sequenceNumber] (optional) is a monotonically increasing sequence number.
+/// [level] (optional) is the severity level (value between 0 and 2000).
+/// [name] (optional) is the name of the source of the log message.
/// [zone] (optional) the zone where the log was emitted
/// [error] (optional) an error object associated with this log event.
/// [stackTrace] (optional) a stack trace associated with this log event.
-external log({int sequenceNumber,
- int millisecondsSinceEpoch,
- int level,
- String name,
- String message,
+external log(String message,
+ DateTime time,
Lasse Reichstein Nielsen 2015/08/04 11:24:54 Could/should we make time optional, and have it de
Cutch 2015/08/04 14:11:40 Done.
+ {int sequenceNumber,
+ int level: 0,
+ String name:'',
Lasse Reichstein Nielsen 2015/08/04 11:24:54 space after ':'.
Cutch 2015/08/04 14:11:40 Done.
Zone zone,
Object error,
StackTrace stackTrace});

Powered by Google App Engine
This is Rietveld 408576698