Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: sdk/lib/_internal/js_runtime/lib/developer_patch.dart

Issue 1266053003: Make dart:developer log more user friendly (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/js_runtime/lib/developer_patch.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/developer_patch.dart b/sdk/lib/_internal/js_runtime/lib/developer_patch.dart
index 8ec8d4380b611354f109d32478094708f3ad8cea..3098b0c886ef4cc7ad794c2af764cde34e0a3e9d 100644
--- a/sdk/lib/_internal/js_runtime/lib/developer_patch.dart
+++ b/sdk/lib/_internal/js_runtime/lib/developer_patch.dart
@@ -7,14 +7,6 @@
import 'dart:_js_helper' show patch;
import 'dart:_foreign_helper' show JS;
-/// If [when] is true, stop the program as if a breakpoint where hit at the
-/// following statement. Returns the value of [when]. Some debuggers may
-/// display [msg].
-/// NOTE: When invoked, the isolate will not return until a debugger
-/// continues execution. When running in the Dart VM the behaviour is the same
-/// regardless of whether or not a debugger is connected. When compiled to
-/// JavaScript, this uses the "debugger" statement, and behaves exactly as
-/// that does.
@patch
@ForceInline()
bool debugger({bool when: true, String msg}) {
@@ -24,28 +16,17 @@ bool debugger({bool when: true, String msg}) {
return when;
}
-/// Send a reference to [object] to any attached debuggers so they may open an
-/// inspector on the object. Returns the argument.
@patch
inspect(object) {
return object;
}
@patch
-/// Emit a log event.
-/// [sequenceNumber] is a monotonically increasing sequence number.
-/// [millisececondsSinceEpoch] is a timestamp.
-/// [level] is the severity level (value between 0 and 2000 inclusive).
-/// [name] is the name of the source of the log message.
-/// [message] is the log message.
-/// [zone] (optional) the zone where the log was emitted
-/// [error] (optional) an error object associated with this log event.
-/// [stackTrace] (optional) a stack trace associated with this log event.
-log({int sequenceNumber,
- int millisecondsSinceEpoch,
- int level,
- String name,
- String message,
+log(String message,
+ DateTime time,
+ {int sequenceNumber,
+ int level = 0,
Lasse Reichstein Nielsen 2015/08/04 11:24:54 '=' should be ':' ? (And yes, it IS annoying that
Cutch 2015/08/04 14:11:40 Done.
+ String name = '',
Zone zone,
Object error,
StackTrace stackTrace}) {

Powered by Google App Engine
This is Rietveld 408576698