Add a commandline flag to chrome to validate crx files

chrome/browser/extensions/startup_helper.h

Index: chrome/browser/extensions/startup_helper.h
diff --git a/chrome/browser/extensions/startup_helper.h b/chrome/browser/extensions/startup_helper.h
index 01ccfa6a0818363d968282dea63149b9c50a8d71..e767b346accee069e2facfba29be653f6cde0534 100644
--- a/chrome/browser/extensions/startup_helper.h
+++ b/chrome/browser/extensions/startup_helper.h
@@ -29,6 +29,10 @@ class StartupHelper : public PackExtensionJob::Client {
   // extension. Returns false if the pack job failed.
   bool PackExtension(const CommandLine& cmd_line);
 
+  // Validates a crx at the path given by the --validate-extension flag - can
+  // it be installed? Returns true if the crx is valid, or false otherwise.

[Matt Perry, 2013/03/20 19:52:15]

The code just unpacks it. That doesn't necessarily mean it can be installed,
right? I forget how much error checking we do at unpack time. Do we check for
valid pemissions, etc?

Also, should we report warnings? Like "The bla permission is not available in
the stable channel." ?

[asargent_no_longer_on_chrome, 2013/03/21 21:34:44]

As discussed offline, I think most 'error' checks have been done by this point,
and the idea about optional output of warnings is a great idea for future
enhancement.

For now I'm leaving this as-is since getting this working in the short term is
helpful for the webstore folks.

+  bool ValidateCrx(const CommandLine& cmd_line);
+
   // Handle --uninstall-extension flag from the |cmd_line| by uninstalling the
   // specified extension from |profile|. Returns false if the uninstall job
   // could not be started.