Add a commandline flag to chrome to validate crx files

chrome/browser/extensions/startup_helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_STARTUP_HELPER_H_
 #define CHROME_BROWSER_EXTENSIONS_STARTUP_HELPER_H_
 
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/extensions/pack_extension_job.h"
 
@@ skipping 11 matching lines @@
   virtual void OnPackSuccess(
       const base::FilePath& crx_path,
       const base::FilePath& output_private_key_path) OVERRIDE;
   virtual void OnPackFailure(const std::string& error_message,
                              ExtensionCreator::ErrorType type) OVERRIDE;
 
   // Handle --pack-extension flag from the |cmd_line| by packing the specified
   // extension. Returns false if the pack job failed.
   bool PackExtension(const CommandLine& cmd_line);
 
+  // Validates a crx at the path given by the --validate-extension flag - can
+  // it be installed? Returns true if the crx is valid, or false otherwise.

[Matt Perry, 2013/03/20 19:52:15]

The code just unpacks it. That doesn't necessarily mean it can be installed,
right? I forget how much error checking we do at unpack time. Do we check for
valid pemissions, etc?

Also, should we report warnings? Like "The bla permission is not available in
the stable channel." ?

[asargent_no_longer_on_chrome, 2013/03/21 21:34:44]

As discussed offline, I think most 'error' checks have been done by this point,
and the idea about optional output of warnings is a great idea for future
enhancement.

For now I'm leaving this as-is since getting this working in the short term is
helpful for the webstore folks.

+  bool ValidateCrx(const CommandLine& cmd_line);
+
   // Handle --uninstall-extension flag from the |cmd_line| by uninstalling the
   // specified extension from |profile|. Returns false if the uninstall job
   // could not be started.
   bool UninstallExtension(const CommandLine& cmd_line, Profile* profile);
 
   // Handle --install-from-webstore flag from |cmd_line| by downloading
   // metadata from the webstore for the given id, prompting the user to
   // confirm, and then downloading the crx and installing it.
   bool InstallFromWebstore(const CommandLine& cmd_line, Profile* profile);
 
@@ skipping 12 matching lines @@
  private:
   scoped_refptr<PackExtensionJob> pack_job_;
   bool pack_job_succeeded_;
 
   DISALLOW_COPY_AND_ASSIGN(StartupHelper);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_STARTUP_HELPER_H_