Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1265983006: Remove serializer-specific hash table size heuristic. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove serializer-specific hash table size heuristic. The heuristic can cause weird behavior when bootstrapping. The memory savings is not worth this hassle. Committed: https://crrev.com/fc80f29a582b758d14aae864232624ca45e47ddc Cr-Commit-Position: refs/heads/master@{#30019} Committed: https://crrev.com/6a2d3ad60676f0a0eac06cc9b8a1e1c547167d5e Cr-Commit-Position: refs/heads/master@{#30026}

Patch Set 1 #

Patch Set 2 : skip failing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M src/api.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (7 generated)
Yang
Please take a look.
5 years, 4 months ago (2015-08-03 08:22:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265983006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265983006/1
5 years, 4 months ago (2015-08-03 11:06:03 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-03 11:37:26 UTC) #6
Yang
On 2015/08/03 11:37:26, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 4 months ago (2015-08-04 05:56:30 UTC) #7
ulan
lgtm
5 years, 4 months ago (2015-08-04 10:54:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265983006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265983006/1
5 years, 4 months ago (2015-08-04 10:55:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 10:57:00 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a246e296c6366dcd0a2d8aa0df973d57093178f6 Cr-Commit-Position: refs/heads/master@{#29992}
5 years, 4 months ago (2015-08-04 10:57:37 UTC) #12
Yang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1257873006/ by yangguo@chromium.org. ...
5 years, 4 months ago (2015-08-04 14:08:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265983006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265983006/1
5 years, 4 months ago (2015-08-05 06:39:09 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 07:35:39 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc80f29a582b758d14aae864232624ca45e47ddc Cr-Commit-Position: refs/heads/master@{#30019}
5 years, 4 months ago (2015-08-05 07:36:03 UTC) #17
Yang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1268413002/ by yangguo@chromium.org. ...
5 years, 4 months ago (2015-08-05 11:45:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265983006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265983006/20001
5 years, 4 months ago (2015-08-05 12:27:27 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 12:51:45 UTC) #22
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 12:52:08 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a2d3ad60676f0a0eac06cc9b8a1e1c547167d5e
Cr-Commit-Position: refs/heads/master@{#30026}

Powered by Google App Engine
This is Rietveld 408576698