Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Issue 1257873006: Revert of Remove serializer-specific hash table size heuristic. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove serializer-specific hash table size heuristic. (patchset #1 id:1 of https://codereview.chromium.org/1265983006/ ) Reason for revert: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/3088/steps/Mjsunit/logs/load-proxy Original issue's description: > Remove serializer-specific hash table size heuristic. > > The heuristic can cause weird behavior when bootstrapping. > The memory savings is not worth this hassle. > > Committed: https://crrev.com/a246e296c6366dcd0a2d8aa0df973d57093178f6 > Cr-Commit-Position: refs/heads/master@{#29992} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/186841f0a07d8925c1138b72c10f253a8ddf3899 Cr-Commit-Position: refs/heads/master@{#30000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M src/api.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Remove serializer-specific hash table size heuristic.
5 years, 4 months ago (2015-08-04 14:08:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257873006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257873006/1
5 years, 4 months ago (2015-08-04 14:08:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 14:09:01 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 14:09:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/186841f0a07d8925c1138b72c10f253a8ddf3899
Cr-Commit-Position: refs/heads/master@{#30000}

Powered by Google App Engine
This is Rietveld 408576698