Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1265983004: Call notifyPixelsChanged after modifying bitmap (Closed)

Created:
5 years, 4 months ago by scroggo_chromium
Modified:
5 years, 4 months ago
Reviewers:
msarett, scroggo, emmaleer
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Call notifyPixelsChanged after modifying bitmap In CodecSrc's scanline_subset test, we decode a subset of an image to a bitmap, draw it to the canvas, and then repeat. This is fine for most backends, but not for pipe. Pipe sees the same generation ID, so it assumes it is the same bitmap it saw before, and just draws the original one. Call notifyPixelsChanged, so the bitmap will get a new generation ID, fixing pipe. BUG=skia:4138 Committed: https://skia.googlesource.com/skia/+/4358f13ac614d572c137e95748c6dc2ca0d66784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M dm/DMSrcSink.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
scroggo_chromium
We may still want to veto pipe from CodecSrcs, but this fixes the bug.
5 years, 4 months ago (2015-07-30 17:58:19 UTC) #2
msarett
lgtm I think this bug is a good reason to make sure that we continue ...
5 years, 4 months ago (2015-07-30 18:20:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265983004/1
5 years, 4 months ago (2015-07-30 18:23:54 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 18:33:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4358f13ac614d572c137e95748c6dc2ca0d66784

Powered by Google App Engine
This is Rietveld 408576698