Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1263013002: Remove SK_LEGACY_IMAGE_GENERATOR_ENUMS_AND_OPTIONS (Closed)

Created:
5 years, 4 months ago by scroggo_chromium
Modified:
5 years, 4 months ago
Reviewers:
scroggo, f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_LEGACY_IMAGE_GENERATOR_ENUMS_AND_OPTIONS Now that Chrome no longer depends on it, remove dead code. Committed: https://skia.googlesource.com/skia/+/ef004e1b49ce6ad488ea4444c0eb896ef37c1242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -188 lines) Patch
M include/core/SkImageGenerator.h View 3 chunks +0 lines, -81 lines 0 comments Download
M src/core/SkImageGenerator.cpp View 2 chunks +0 lines, -22 lines 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 5 chunks +0 lines, -46 lines 0 comments Download
M src/ports/SkImageGenerator_skia.cpp View 3 chunks +0 lines, -21 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 2 chunks +0 lines, -18 lines 0 comments Download

Dependent Patchsets:

Issue 1267583002 Patch 40001
Issue 1267583002 Patch 60001
Issue 1267583002 Patch 80001
Issue 1265983004 Patch 1

Messages

Total messages: 7 (2 generated)
scroggo_chromium
Florin, thanks for cleaning up my mess in Chromium/Blink. Here is the Skia cleanup
5 years, 4 months ago (2015-07-30 14:27:03 UTC) #2
reed1
automatic LGTM for CLs that delete code
5 years, 4 months ago (2015-07-30 14:28:25 UTC) #3
f(malita)
LGTM++!
5 years, 4 months ago (2015-07-30 14:29:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263013002/1
5 years, 4 months ago (2015-07-30 14:32:35 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 14:47:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ef004e1b49ce6ad488ea4444c0eb896ef37c1242

Powered by Google App Engine
This is Rietveld 408576698