components/dom_distiller/content/common/distiller_javascript_service.mojom - Issue 1265843005: Refactor feedback to use native JS object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/common/distiller_javascript_service.mojom

Issue 1265843005: Refactor feedback to use native JS object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@js-mojo-combine

Patch Set: impl comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/browser/dom_distiller_viewer_source.cc ('k') | components/dom_distiller/content/renderer/distiller_native_javascript.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/common/distiller_javascript_service.mojom

diff --git a/components/dom_distiller/content/common/distiller_javascript_service.mojom b/components/dom_distiller/content/common/distiller_javascript_service.mojom

index cf7b7a04b9476dca9a40e5054bef086b535b426f..5316744993170f2154c23fd4c2076303c5321fb1 100644

--- a/components/dom_distiller/content/common/distiller_javascript_service.mojom

+++ b/components/dom_distiller/content/common/distiller_javascript_service.mojom

@@ -7,5 +7,10 @@ module dom_distiller;

// This service is implemented by the browser process and is used by the

// renderer when a distiller JavaScript function is called.

interface DistillerJavaScriptService {

+ // Handle the "distiller.echo" function.

HandleDistillerEchoCall(string message);

+ // Handle the "distiller.sendFeedback" function.

+ HandleDistillerFeedbackCall(bool good);

};