components/dom_distiller/content/common/distiller_javascript_service.mojom - Issue 1265843005: Refactor feedback to use native JS object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/content/common/distiller_javascript_service.mojom

Issue 1265843005: Refactor feedback to use native JS object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@js-mojo-combine

Patch Set: impl comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module dom_distiller;	5 module dom_distiller;

6	6

7 // This service is implemented by the browser process and is used by the	7 // This service is implemented by the browser process and is used by the

8 // renderer when a distiller JavaScript function is called.	8 // renderer when a distiller JavaScript function is called.

9 interface DistillerJavaScriptService {	9 interface DistillerJavaScriptService {

	10

	11 // Handle the "distiller.echo" function.

10 HandleDistillerEchoCall(string message);	12 HandleDistillerEchoCall(string message);

	13

	14 // Handle the "distiller.sendFeedback" function.

	15 HandleDistillerFeedbackCall(bool good);

11 };	16 };

OLD	NEW