chrome/browser/devtools/device/usb/android_usb_browsertest.cc - Issue 1265833005: Get all the UsbConfigDescriptor for the device configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

Issue 1265833005: Get all the UsbConfigDescriptor for the device configuration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated code to continue instead of return if error happens when getting config descriptor Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc ('k') | chrome/browser/devtools/device/usb/android_usb_device.cc » ('j') | device/usb/usb_device.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

diff --git a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

index 7f73ba65dcff86f711d4668b7a54639e254458a0..6045a820bf04b2eea3db45c7f1c7306af95220ab 100644

--- a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

+++ b/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

@@ -17,7 +17,6 @@

#include "chrome/test/base/in_process_browser_test.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/test/test_utils.h"

-#include "device/usb/usb_descriptors.h"

#include "device/usb/usb_device.h"

#include "device/usb/usb_device_handle.h"

#include "device/usb/usb_service.h"

@@ -415,7 +414,7 @@ class MockUsbDevice : public UsbDevice {

new MockUsbDeviceHandle<T>(this))));

}

- const UsbConfigDescriptor* GetConfiguration() override {

+ const UsbConfigDescriptor* GetActiveConfiguration() override {

return T::kConfigured ? &config_desc_ : nullptr;

}