chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc - Issue 1265833005: Get all the UsbConfigDescriptor for the device configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

Issue 1265833005: Get all the UsbConfigDescriptor for the device configuration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated code to continue instead of return if error happens when getting config descriptor Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

diff --git a/chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc b/chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

index d63d6e35e372b92d4c428e5e4adac933d32bc8ed..21149e3a588476dcaef87903825520a7f97f163f 100644

--- a/chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

+++ b/chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc

@@ -20,7 +20,6 @@

#include "content/public/test/test_browser_thread_bundle.h"

#include "device/core/device_client.h"

#include "device/usb/mock_usb_service.h"

-#include "device/usb/usb_descriptors.h"

#include "device/usb/usb_device.h"

#include "device/usb/usb_service.h"

#include "extensions/browser/extension_registry.h"

@@ -73,7 +72,7 @@ class FakeUsbDevice : public device::UsbDevice {

return false;

}

- const device::UsbConfigDescriptor* GetConfiguration() override {

+ const device::UsbConfigDescriptor* GetActiveConfiguration() override {

return config_.get();

}

« no previous file with comments | « no previous file | chrome/browser/devtools/device/usb/android_usb_browsertest.cc » ('j') | device/usb/usb_device.h » ('J')