Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1265723003: [turbofan] Fix kArchTailCallCodeObject on ia32/x64. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
ssh://rmcilroy.lon.corp.google.com///usr/local/google/code/v8_full/v8@inter_linkage_change
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix kArchTailCallCodeObject on ia32/x64. Previously these instructions tried to jump to the value at the code entry's location, rather than jumping to this location. Also adds a test. BUG=v8:4280 LOG=N Committed: https://crrev.com/ec9bc7947399e29429c3bdeaff070db2a4cc92f4 Cr-Commit-Position: refs/heads/master@{#29949}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
rmcilroy
PTAL. As discussed, this will be tested byhttps://codereview.chromium.org/1269683002/, but I will add an explicit test ...
5 years, 4 months ago (2015-07-31 09:47:11 UTC) #3
titzer
lgtm
5 years, 4 months ago (2015-07-31 09:48:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265723003/20001
5 years, 4 months ago (2015-07-31 09:56:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-07-31 10:20:11 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 10:20:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec9bc7947399e29429c3bdeaff070db2a4cc92f4
Cr-Commit-Position: refs/heads/master@{#29949}

Powered by Google App Engine
This is Rietveld 408576698