Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1254293006: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, picksi1, oth
Base URL:
ssh://rmcilroy.lon.corp.google.com///usr/local/google/code/v8_full/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Change interpreter to use an BytecodeArray pointer and and offset. Changes the interpreter to use a BytecodeArray pointer and an offset to avoid having an inner pointer to a BytecodeArray object in registers during dispatch. BUG=v8:4280 LOG=N Committed: https://crrev.com/597da503220ab2a632453d2e3a915e9824d6d592 Cr-Commit-Position: refs/heads/master@{#29910}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove inadvertent flags changes #

Patch Set 3 : Fix MIPS merge error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -56 lines) Patch
M src/compiler/arm/linkage-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/interpreter-assembler.h View 2 chunks +7 lines, -5 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 4 chunks +22 lines, -14 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 chunk +10 lines, -6 lines 0 comments Download
M src/compiler/mips/linkage-mips.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/mips64/linkage-mips64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ppc/linkage-ppc.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 4 chunks +15 lines, -18 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
rmcilroy
Benedikt, could you take a look please.
5 years, 4 months ago (2015-07-28 12:45:57 UTC) #2
Benedikt Meurer
LGTM with comment. https://codereview.chromium.org/1254293006/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1254293006/diff/1/src/flag-definitions.h#newcode283 src/flag-definitions.h:283: DEFINE_BOOL(ignition, true, "use ignition interpreter") Is ...
5 years, 4 months ago (2015-07-29 08:10:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254293006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254293006/20001
5 years, 4 months ago (2015-07-29 18:53:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/3179)
5 years, 4 months ago (2015-07-29 18:56:35 UTC) #8
rmcilroy
https://codereview.chromium.org/1254293006/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1254293006/diff/1/src/flag-definitions.h#newcode283 src/flag-definitions.h:283: DEFINE_BOOL(ignition, true, "use ignition interpreter") On 2015/07/29 08:10:38, Benedikt ...
5 years, 4 months ago (2015-07-29 19:02:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254293006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254293006/40001
5 years, 4 months ago (2015-07-29 19:07:43 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-30 08:18:26 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 08:18:35 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/597da503220ab2a632453d2e3a915e9824d6d592
Cr-Commit-Position: refs/heads/master@{#29910}

Powered by Google App Engine
This is Rietveld 408576698