Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1265623002: Add builder_spec.py (Closed)

Created:
5 years, 4 months ago by borenet
Modified:
5 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add builder_spec.py Works like dm_flags.py and nanobench_flags.py; adds things like GYP_DEFINES, additional environment variables, and build targets. Required copying builder_name_schema from the tools/build repo. BUG=skia:4132 Committed: https://skia.googlesource.com/skia/+/b76c1f706c40693740a8f7cc376bd603b417e8a3

Patch Set 1 #

Total comments: 5

Patch Set 2 : Don't build nanobench on Test-...-Release bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -0 lines) Patch
A tools/buildbot_spec.json View 1 1 chunk +129 lines, -0 lines 0 comments Download
A tools/buildbot_spec.py View 1 1 chunk +240 lines, -0 lines 0 comments Download
A tools/builder_name_schema.json View 1 chunk +40 lines, -0 lines 0 comments Download
A tools/builder_name_schema.py View 1 chunk +194 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
borenet
https://codereview.chromium.org/1265623002/diff/1/tools/buildbot_spec.py File tools/buildbot_spec.py (right): https://codereview.chromium.org/1265623002/diff/1/tools/buildbot_spec.py#newcode35 tools/buildbot_spec.py:35: def gyp_defines(builder_dict): These functions are copied verbatim from https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipe_modules/skia/config.py ...
5 years, 4 months ago (2015-07-29 13:38:57 UTC) #2
mtklein
lgtm https://codereview.chromium.org/1265623002/diff/1/tools/buildbot_spec.py File tools/buildbot_spec.py (right): https://codereview.chromium.org/1265623002/diff/1/tools/buildbot_spec.py#newcode163 tools/buildbot_spec.py:163: return ['dm', 'nanobench'] It occurs to me that ...
5 years, 4 months ago (2015-07-29 13:47:52 UTC) #3
borenet
https://codereview.chromium.org/1265623002/diff/1/tools/buildbot_spec.py File tools/buildbot_spec.py (right): https://codereview.chromium.org/1265623002/diff/1/tools/buildbot_spec.py#newcode163 tools/buildbot_spec.py:163: return ['dm', 'nanobench'] On 2015/07/29 13:47:52, mtklein wrote: > ...
5 years, 4 months ago (2015-07-29 13:57:12 UTC) #4
mtklein
lgtm!
5 years, 4 months ago (2015-07-29 13:58:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265623002/20001
5 years, 4 months ago (2015-07-29 14:31:11 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 14:38:52 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b76c1f706c40693740a8f7cc376bd603b417e8a3

Powered by Google App Engine
This is Rietveld 408576698