Source/core/dom/shadow/ShadowRoot.h - Issue 1265573003: Fix crash on null ptr dereference in EventPath propagation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ShadowRoot.h

Issue 1265573003: Fix crash on null ptr dereference in EventPath propagation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: update the comment (not necessarily async events) Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/shadow/ShadowRoot.h

diff --git a/Source/core/dom/shadow/ShadowRoot.h b/Source/core/dom/shadow/ShadowRoot.h

index add60a488592933e33148b90dcfb70cb7630da8a..a3f45777c0eb04da3f2b50902d37d4e0cd9729ef 100644

--- a/Source/core/dom/shadow/ShadowRoot.h

+++ b/Source/core/dom/shadow/ShadowRoot.h

@@ -70,6 +70,8 @@ public:

using TreeScope::document;

using TreeScope::getElementById;

+ // TODO(kochi): crbug.com/507413 In non-Oilpan, host() may return null during queued

+ // event handling (e.g. during execCommand()).

Element* host() const { return toElement(parentOrShadowHostNode()); }

ElementShadow* owner() const { return host() ? host()->shadow() : 0; }

« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/events/EventPath.cpp » ('j') | no next file with comments »